-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATEST-288: Fix Failing Test: AddUserTest #299
Conversation
@kdaud , @sherrif10 , @dkayiwa Please find some time to review my PR. Thank you very much. |
assertFalse(addEditUserPage.isDataCorrect(validationErrors)); | ||
|
||
addEditUserPage.enterGivenFamily("Super", "Nurse"); | ||
addEditUserPage.saveUser(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is working fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is working fine
@sherrif10 it is working fine on my side, I have just rerun it again. I just want to look into the reason why it's failing here.
assertTrue(validationErrors.contains("Cannot be empty or null")); | ||
assertFalse(addEditUserPage.isDataCorrect(validationErrors)); | ||
|
||
addEditUserPage.enterGivenFamily("Super", "Nurse"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for removing the assertions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for removing the assertions?
@kdaud initially the test was made to rely on addEditUserPage, however, It should rely on CreateNewUserPage. Now given the coupling of methods in the createNewUserPage, there's no room for errors. You could advise me on the best approach to take @kdaud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for switching the test from using AddEditUserPage
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdaud the actual page that is meant to implement it is the CreateNewUserPage, you follow their URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two ways of creating user account and the test is using the legacy ui captured in second option on the talk post. You need to investigate why the test is failing the validation declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the test clicks save user and the validation errors are displayed, it looks like the session is killed and the test can not proceed after that.
@Irenyak1 investigate why the test run is killed at that point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdaud did you take time to look into the error logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is why I made the comment above !
What were your findings ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What were your findings ?
haven't investigated since you're looking into the test.
Will have this closed in favor of #364 |
Ticket -> RATEST-288
Fixed -> Failing legacy Test, Add User Test.